4 comments:
Please elaborate, what the highest frequency is, and give concrete boottime numbers without and with the change.
File src/soc/mediatek/mt8192/dramc_dvfs.c:
Patch Set #40, Line 34: perfctl0_bak = (read32(&ch[0].ao.perfctl0) >> 10) & 0x3;
Is this in the right if branch?
if (wa_enable) {
perfctl0_bak = (read32(&ch[0].ao.perfctl0) >> 10) & 0x3;
SET32_BITFIELDS(&ch[0].ao.perfctl0,
PERFCTL0_RWAGEEN, 0,
PERFCTL0_EMILLATEN, 0);
} else {
SET32_BITFIELDS(&ch[0].ao.perfctl0,
PERFCTL0_RWAGEEN, perfctl0_bak & 0x1,
PERFCTL0_EMILLATEN, (perfctl0_bak >> 1) & 0x1);
}
I’d use the ternary operator:
wa_enable ? 0 : PERFCTL0_RWAGEEN, perfctl0_bak & 0x1
Patch Set #40, Line 49: u8 ack_state = 0, complete = 1;
Why not use a boolean?
To view, visit change 44730. To unsubscribe, or for help writing mail filters, visit settings.