Patch Set 2:

Patch Set 2:

Patch Set 2: Code-Review+1

AGESA resume from S3 still works with G505S with this. Although - if combined with a new "CONFIG_SECURITY_CLEAR_DRAM_ON_REGULAR_BOOT" - S3 stops working (haven't tested this config alone yet).

Always clear the DRAM after DRAM initialization regardless of additional security implementations in use.
This increases boot time depending on the amount of DRAM installed.

AGESA has valuables in low memory and coreboot does not really keep account of them. I think it's BIOS_HEAP_START_ADDRESS + _SIZE you are not allowed to clear. So I expect S3 resume with that CLEAR_DRAM feature enabled to fail regardless of this commit.

Yes, indeed S3 is always failing if DRAM clearing is enabled, even without your commit.

Thanks for testing!

View Change

To view, visit change 33956. To unsubscribe, or for help writing mail filters, visit settings.