Patch Set 8:

Still wondering about my question in patch set #5 below?

Line 80:
Sorry, updating the last comment. Is PCIe port 3 being used for testing at the moment? if that's the case, then can we not commit the changes for now? This is not consistent with the current schematics.

I have changed from PCIe port 3 to PCIe port 8 in patch set #8. But this is just reserved and not being used at the moment. I will remove it in next patch.

View Change

8 comments:

• Commit Message:

  • Patch Set #6, Line 7: mb/google/hatch: modify PCIe ports setting for mushu

    mb/google/hatch/var/mushu: Correct PCIe port configuration

    Done

  • Patch Set #6, Line 9: Enabled

    Enable

    Done

  • Patch Set #6, Line 10: prot

    port

    Done

  • Patch Set #6, Line 11: Enabled

    Enable

    Done

• File src/mainboard/google/hatch/variants/mushu/overridetree.cb:

  • Patch Set #6, Line 67: # Enable Root port 13(x4) for dGPU.

    Please remove the dot at the end.

    Done

  • Patch Set #6, Line 67: 13(x4)

    Please add a space before (.

    Done

  • Patch Set #6, Line 75: # PCIe port 8 reserve for GPU REFCLK

    … reserve*d* for …

    Done

  • Patch Set #6, Line 87: register "PcieClkSrcClkReq[3]" = "3"

    I agree. […]

    Done

To view, visit change 38399. To unsubscribe, or for help writing mail filters, visit settings.