5 comments:
File src/mainboard/google/hatch/variants/kohaku/memory.c:
Patch Set #8, Line 66: __weak
Why is weak added here?
My fault over c&p.
Just removed it.
for (int i = 0; i < NUM_DIMM_SLOT; i++) {
if (is_single_ch_mem && i >= (NUM_DIMM_SLOT / 2))
bcfg->spd[i].read_type = NOT_EXISTING;
else {
bcfg->spd[i].read_type = READ_SPD_CBFS;
bcfg->spd[i].spd_spec.spd_index = mem_sku;
}
What Furquan said. […]
Fixed and removed the common code to romstage.c.
Thanks for pointing out this error.
File src/soc/intel/cannonlake/cnl_memcfg_init.c:
Patch Set #8, Line 114: struct spd_info spdi;
Just use a pointer? struct spd_info *spdi;
Done
Patch Set #8, Line 122: spdi = cnl_cfg->spd[i];
As Furquan suggested, use a pointer. […]
Done
Patch Set #8, Line 131: cnl_cfg
Why not just pass in spd_index here?
Good idea. Fixed.
To view, visit change 32513. To unsubscribe, or for help writing mail filters, visit settings.