7 comments:
File src/mainboard/protectli/vault_bsw/acpi/superio.asl:
Patch Set #14, Line 9: #include "onboard.h"
I'm not seeing this used below
File src/mainboard/protectli/vault_bsw/devicetree.cb:
# LPE audio codec settings
register "lpe_codec_clk_src" = "LPE_CLK_SRC_PLL" # 19.2MHz clock
is LPE audio being used?
Patch Set #14, Line 80: Disable devices in ACPI mode
perhaps 'Disable use of ACPI mode' since the devices aren't being disabled, just set to use PCI mode
device pnp 2e.4 off # Environment Controller
end
device pnp 2e.5 off # Keyboard
end
device pnp 2e.6 off # Mouse
end
device pnp 2e.7 off # GPIO
end
device pnp 2e.a off # CIR
end
seems like these could all be single line, like 2e.0 above
File src/mainboard/protectli/vault_bsw/dsdt.asl:
Scope (\_SB) {
Device (PCI0)
{
#include <acpi/southcluster.asl>
}
}
Scope (\_SB.PCI0)
{
Device (RP03)
{
Name (_ADR, 0x001C0002) // _ADR: Address
OperationRegion(RPXX, PCI_Config, 0x00, 0x10)
}
}
combine since same scope?
File src/mainboard/protectli/vault_bsw/fadt.c:
static, or use get_acpi_table_revision() ?
File src/mainboard/protectli/vault_bsw/hda_verb.c:
is this used? I wouldn't think so since SOC_INTEL_COMMON_BLOCK_HDA_VERB isn't selected anywhere
To view, visit change 32076. To unsubscribe, or for help writing mail filters, visit settings.