16 comments:
We can still assume that it contains at least the header.
Done
Patch Set #11, Line 45: and must be set to 0
Only until a platform starts to use them. It seems at least APL does.
Then they violate the spec.
Patch Set #11, Line 58: * Bit 7 indicates whether component has valid checksum.
mention C_V? as it's referred to as that below
Done
Patch Set #11, Line 182: but only mentioned on page 22 of
It is mentioned below "FIT Ordering Rules" in all specifications I know.
Ack
if (fit_table_entries(fit) <= 1)
return;
What difference does it make?
None. Removed.
Patch Set #11, Line 256: cbfs_file_get_header(&buf, &header);
`buf.offset` (and `. […]
Done
Patch Set #11, Line 263: ssize_t
why not `size_t`?
Done
Patch Set #11, Line 264: total_entries
isn't this more like `max_entries`?
Done
Patch Set #11, Line 332: zero or multiple
or one? […]
Done
Patch Set #11, Line 443: entires
entries
Done
Patch Set #11, Line 443: ERROR("Maximum of FIT entires reached.\n");
free(mcus);
Done
Patch Set #11, Line 450: mcus[i].offset),
NB. Looking through the code this still only works if the CBFS is memory […]
Nobody cared until this point.
sort?
no as fit_add_entry sorts already
Patch Set #11, Line 480: fit_pointer[1] != 0
Any hint that it's a 64-bit pointer? otherwise it wouldn't be specified what […]
@Aaron As you added the code, where do you got this from?
Patch Set #11, Line 533: break;
`break` is usually indented.
Done
PRIx64
Done
To view, visit change 31493. To unsubscribe, or for help writing mail filters, visit settings.