Attention is currently required from: Jeff Daly, Paul Menzel, Stefan Reinauer, Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60736 )
Change subject: util/ifdtool: Add additional regions for platforms that support them
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60736/comment/0955ac3c_f5367c98
PS4, Line 9:
nit: trailing space
https://review.coreboot.org/c/coreboot/+/60736/comment/0122dadb_0daa438d
PS4, Line 10: FW
I'd spell out `firmware` here for consistency with `Innovation Engine firmware`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60736
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64cc1d787f15a01dff7db89218410228fd0082a6
Gerrit-Change-Number: 60736
Gerrit-PatchSet: 4
Gerrit-Owner: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 05 Jan 2022 14:09:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment