Patch Set 5:

By comparing the gpio.c generated by autoport on a t430s that have a TB and the gpio.c in coreboot's tree, I fount that gpio27 is set as GPIO-INPUT on devices that have a TB, while it is set as GPIO-OUTPUT-HIGH on the gpio.c in coreboot's tree (it might reflex the config of devices that do not have a TB).

Is gpio27 the detection gpio for TB we are looking for? And if it is, what should be done to the code in the next step?

It might be used for TB, but I would expect the GPIO to be input on all boards. It would change level if TB is installed, compared to a board where it isn't.

If you want to add a TODO that's fine for me.

Patch set 5:Code-Review +2

View Change

To view, visit change 31631. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61f41db100f398069e50e2da8a378b3a8d1c84bf
Gerrit-Change-Number: 31631
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 16 Sep 2019 07:01:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment