Attention is currently required from: Justin Frodsham, Raul Rangel, Subrata Banik, Andrey Petrov, Patrick Rudolph, Felix Held.
Hello Justin Frodsham, build bot (Jenkins), Raul Rangel, Furquan Shaikh, Subrata Banik, Andrey Petrov, Patrick Rudolph, Justin Frodsham,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50090
to look at the new patch set (#3).
Change subject: drivers/intel/fsp2_0: factor out and improve UPD signature check
......................................................................
drivers/intel/fsp2_0: factor out and improve UPD signature check
In case of a mismatch print both the UPD signature in the FSP and the
expected signature and then calls die(), since it shouldn't try calling
into the wrong FSP binary for the platform.
Signed-off-by: Justin Frodsham justin.frodsham@protonmail.com
Signed-off-by: Felix Held felix-coreboot@felixheld.de
Change-Id: I469836e09db6024ecb448a5261439c66d8e65daf
---
M src/drivers/intel/fsp2_0/include/fsp/util.h
M src/drivers/intel/fsp2_0/memory_init.c
M src/drivers/intel/fsp2_0/silicon_init.c
M src/drivers/intel/fsp2_0/util.c
4 files changed, 19 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/50090/3
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50090
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I469836e09db6024ecb448a5261439c66d8e65daf
Gerrit-Change-Number: 50090
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: newpatchset