Attention is currently required from: Ed Sharma, Johnny Lin, Jonathan Zhang, Paul Menzel.

View Change

2 comments:

• File src/commonlib/fsp_relocate.c:

  • Patch Set #4, Line 230: offset_limit = roffset + rsize;

    Fixes issue reported as below: […]

    As with below, this doesn't fix the problem that the roffset and rsize are not sanity checked before using them.

  • Patch Set #4, Line 258: ptr = &pe_base[aoff];

    Fixes the below reported Coverity issue. […]

    This doesn't verify the value though, so while it may get around the coverity warning, it doesn't "fix" it.

    To fix the problem, you need to make sure that aoff is a reasonable value before using it as the offset.

To view, visit change 68637. To unsubscribe, or for help writing mail filters, visit settings.