Attention is currently required from: Cliff Huang, David Ruth, Lance Zhao, Paul Menzel, Subrata Banik, Subrata Banik, Tim Wawrzynczak.

Patch set 8:Code-Review +1

View Change

2 comments:

• File src/drivers/wifi/generic/mtcl.c:

  • Patch Set #8, Line 52: cbfs_map(WIFI_MTCL_CBFS_DEFAULT_FILENAME, &mtcl_bin_len);

    Why not use this pointer instead of having the caller provide a buffer (which may be too small btw). You'd have to unmap later after ACPI generation, but can skip the copying.

• File src/include/mtcl.h:

  • Patch Set #8, Line 21: __packed

    Not necessary as all entries are u8?

To view, visit change 80170. To unsubscribe, or for help writing mail filters, visit settings.