Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35792 )
Change subject: mb/facebook/fbg1701: Add Kingston B511ECMDXGGB memory support
......................................................................
Patch Set 1:
I'd move mainboard_read_pcb_version() to a newly created onboard.c (onboard.h already contains the addresses of the cpld where you read the version id from) and link that in both rom- and ramstage; when linking mainboard.c in romstage you also pull in some ramstage-specifig things from mainboard.c. The patch also needs a rebase
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35792
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e1d1b933d5a49a7005685ed530c882429019027
Gerrit-Change-Number: 35792
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 05 Oct 2019 11:13:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment