Attention is currently required from: Maulik V Vaghela, Paul Menzel, Mario Scheithauer, Subrata Banik, Patrick Rudolph. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55034 )
Change subject: soc/intel/elkhartlake: Update FSP-S UPD RP & USB related configs ......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55034/comment/cc5d7cf7_68ffd714 PS3, Line 7: soc/intel/elkhartlake: Update FSP-S UPD related configs part 3
Add least here, you can mention RP and USB in the commit message summary instead of using *part 3*.
Done
File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55034/comment/38e86b3c_ebe3cdae PS3, Line 184: params->Usb2OverCurrentPin[i] = 0xff;
I find the ternary operator in these cases, where the assignment of only one variable depends on the […]
This is sweet. thanks!
https://review.coreboot.org/c/coreboot/+/55034/comment/e2e07f8e_f2bbdb9b PS3, Line 226: params->PcieRpLtrMaxNoSnoopLatency[i] = 0x1003; //Max No Snoop Latency
Please add a space after `//`. […]
Done
https://review.coreboot.org/c/coreboot/+/55034/comment/b6daf5f7_e7fb55c0 PS3, Line 227: params->PcieRpLtrMaxSnoopLatency[i] = 0x1003; //Max Snoop Latency
Ditto.
Done