Everything still seems to be working OK with this commit. The only observed difference on G505S is " ... raise SMI#" at cbmem log:

...
Enabling cache
Setting up local APIC...
apic_id: 0x13 done.
siblings = 03, Initializing SMM for CPU 3
CPU #3 initialized
All AP CPUs stopped (47 loops)
CPU0: stack: afed4000 - afed5000, lowest used address afed456c, stack used: 2708 bytes
CPU1: stack: afed3000 - afed4000, lowest used address afed3dbc, stack used: 580 bytes
CPU2: stack: afed2000 - afed3000, lowest used address afed2dbc, stack used: 580 bytes
CPU3: stack: afed1000 - afed2000, lowest used address afed1dbc, stack used: 580 bytes
... raise SMI#
CPU_CLUSTER: 0 init finished in 85935943 usecs
DOMAIN: 0000 init ...
DOMAIN: 0000 init finished in 0 usecs
PCI: 00:00.0 init ...
...

Patch set 8:Code-Review +1

View Change

To view, visit change 21624. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a6b63c535b51cc6ff6847b78616134c8506ad28
Gerrit-Change-Number: 21624
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 16 Nov 2019 15:07:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment