4 comments:
File src/drivers/intel/fsp2_0/Kconfig:
Patch Set #11, Line 27: impacts
impact
File src/drivers/intel/fsp2_0/include/fsp/info_header.h:
Patch Set #11, Line 33: size_t multi_phase_si_init_entry_offset;
Doesn't this make the struct layout incompatible with FSP 2.1?
File src/drivers/intel/fsp2_0/include/fsp/util.h:
Patch Set #11, Line 36: uint32_t phase_index
Are these phase indices enumerated? If so, I'd use an enum for this
File src/drivers/intel/fsp2_0/silicon_init.c:
Patch Set #11, Line 57: BIOS_SPEW
BIOS_EMERG
Or just have a single line:
die_with_post_code(postcode, "FspSiliconInit returned with error 0x%08x\n", status);
To view, visit change 41728. To unsubscribe, or for help writing mail filters, visit settings.