Julius Werner submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Paul Fagerburg: Looks good to me, approved
tests: Add lib/b64_decode-test test case

Implement unit tests for lib/b64_decode module.

Signed-off-by: Anna Karas <aka@semihalf.com>
Change-Id: Id5fe9272e30eaff3d086a95241b3819101089c2b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42313
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M tests/lib/Makefile.inc
A tests/lib/b64_decode-test.c
2 files changed, 71 insertions(+), 0 deletions(-)

diff --git a/tests/lib/Makefile.inc b/tests/lib/Makefile.inc
index c490317..5d47fea 100644
--- a/tests/lib/Makefile.inc
+++ b/tests/lib/Makefile.inc
@@ -1,6 +1,10 @@
# SPDX-License-Identifier: GPL-2.0-only

tests-y += string-test
+tests-y += b64_decode-test

string-test-srcs += tests/lib/string-test.c
string-test-srcs += src/lib/string.c
+
+b64_decode-test-srcs += tests/lib/b64_decode-test.c
+b64_decode-test-srcs += src/lib/b64_decode.c
diff --git a/tests/lib/b64_decode-test.c b/tests/lib/b64_decode-test.c
new file mode 100644
index 0000000..452c67f
--- /dev/null
+++ b/tests/lib/b64_decode-test.c
@@ -0,0 +1,67 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <stddef.h>
+#include <stdint.h>
+#include <stdlib.h>
+#include <string.h>
+#include <b64_decode.h>
+#include <tests/test.h>
+
+struct messages_t {
+ const char *enc;
+ const char *dec;
+} messages[] = {
+ {"QQ==", "A"},
+ {"Q\r\nUI=", "AB"},
+ {"QUJD", "ABC"},
+ {"\nQUJDRA==", "ABCD"},
+ {"SGVsbG8\r=", "Hello"},
+ {"SGVsbG8h", "Hello!"}
+};
+
+const char *invalid[] = {
+ "QQ=-=",
+ "SGVsbG-8="
+};
+
+/* Provide necessary definition in order to satisfy dependencies. */
+int do_printk(int msg_level, const char *fmt, ...)
+{
+ return 0;
+}
+
+static void test_b64_decode(void **state)
+{
+ uint8_t *decoded;
+ size_t res;
+
+ for (int i = 0; i < ARRAY_SIZE(messages); i++) {
+ decoded = malloc(strlen(messages[i].enc) * sizeof(char));
+
+ res = b64_decode((uint8_t *)messages[i].enc, strlen(messages[i].enc), decoded);
+
+ assert_int_equal(res, (strlen(messages[i].dec)));
+ assert_string_equal(decoded, messages[i].dec);
+
+ free(decoded);
+ }
+
+ for (int i = 0; i < ARRAY_SIZE(invalid); i++) {
+ decoded = malloc(strlen(invalid[i]) * sizeof(char));
+
+ res = b64_decode((uint8_t *)invalid[i], strlen(invalid[i]), decoded);
+
+ assert_int_equal(res, 0);
+
+ free(decoded);
+ }
+}
+
+int main(void)
+{
+ const struct CMUnitTest tests[] = {
+ cmocka_unit_test(test_b64_decode),
+ };
+
+ return cmocka_run_group_tests(tests, NULL, NULL);
+}

To view, visit change 42313. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5fe9272e30eaff3d086a95241b3819101089c2b
Gerrit-Change-Number: 42313
Gerrit-PatchSet: 4
Gerrit-Owner: Anna Karaƛ <aka@semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd@semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg@chromium.org>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged