Patch Set 2:

Patch Set 2:

Patch Set 2:

Patch Set 2:

Hi Frans -- do you have any feedback? I have a stack of CLs cleaning up the mess of vboot versions that is blocked on this Eltan patch.

https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1961714

Hi Joel,
I will provide an update tomorrow.

We suggest using standard VBoot library and not creating a fork.
Might be able to replace call to vb21_unpack_key() and vb21_verify_data() to the vb2 variant of these functions.

Hi Frans,

That would work fine, if we can get you switched over to using vboot 2 data structures, and using public functions advertised in 2api.h. Would that be do-able from your end?

Joel

Using public functions only might be an issue:
vb21_unpack_key -> vb2_unpack_key_buffer = NO API
vb21_verify_data -> vb2_verify_data = NO API

Would using vb2_init_hash() work to replace these?

vb2_digest_buffer NO API

security/vboot is using this function also. Will security/vboot be modified using API function only?

View Change

To view, visit change 37654. To unsubscribe, or for help writing mail filters, visit settings.