Tim Wawrzynczak has uploaded this change for review.

View Change

drivers/pcie/generic: Add new pcie generic chip driver

This new chip driver will be used for attaching ACPI properties to PCIe
endpoints. The first property it supports is "UntrustedDevice." This
property can be used by a payload to, e.g., restrict the device to its
own IOMMU domain for security purposes. The new property is added by
adding a _DSD and an integer property set to 1.

Example of the property from google/brya0:

Scope (\_SB.PCI0.RP01)
{
    Device (DEV0)
    {
        Name (_ADR, 0x0000000000000000)  // _ADR: Address
        Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
        {
            ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
            Package (0x01)
            {
                Package (0x02)
                {
                    "UntrustedDevice",
                    One
                }
            }
        })
    }
}

BUG=b:215424986
TEST=boot patch train on google/brya0, dump SSDT, see above for snippet

Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Change-Id: I53986614dcbf4d10a6bb4010e131f5ff5a9d25cf
---
A src/drivers/pcie/generic/Kconfig
A src/drivers/pcie/generic/Makefile.inc
A src/drivers/pcie/generic/chip.h
A src/drivers/pcie/generic/generic.c
4 files changed, 82 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/61627/1

diff --git a/src/drivers/pcie/generic/Kconfig b/src/drivers/pcie/generic/Kconfig
new file mode 100644
index 0000000..f3a8441
--- /dev/null
+++ b/src/drivers/pcie/generic/Kconfig
@@ -0,0 +1,11 @@
+config DRIVERS_PCIE_GENERIC
+	bool
+	default n
+	depends on HAVE_ACPI_TABLES
+	help
+	  This driver allows attaching arbitrary ACPI properties to
+	  arbitrary PCI root ports or devices. Currently it supports one
+	  property, "UntrustedDevice" which can be used by indicate to
+	  the operating system that this device may be considered
+	  untrusted, and appropriate policies, e.g. IO/MMU isolation,
+	  should take place.
diff --git a/src/drivers/pcie/generic/Makefile.inc b/src/drivers/pcie/generic/Makefile.inc
new file mode 100644
index 0000000..f634f25
--- /dev/null
+++ b/src/drivers/pcie/generic/Makefile.inc
@@ -0,0 +1 @@
+ramstage-$(CONFIG_DRIVERS_PCIE_GENERIC) += generic.c
diff --git a/src/drivers/pcie/generic/chip.h b/src/drivers/pcie/generic/chip.h
new file mode 100644
index 0000000..f122a55
--- /dev/null
+++ b/src/drivers/pcie/generic/chip.h
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#ifndef _PCIE_GENERIC_H_
+#define _PCIE_GENERIC_H_
+
+struct drivers_pcie_generic_config {
+	bool is_untrusted;
+};
+
+#endif /* _PCIE_GENERIC_H_ */
diff --git a/src/drivers/pcie/generic/generic.c b/src/drivers/pcie/generic/generic.c
new file mode 100644
index 0000000..275fd3c
--- /dev/null
+++ b/src/drivers/pcie/generic/generic.c
@@ -0,0 +1,60 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <acpi/acpi.h>
+#include <acpi/acpigen.h>
+#include <acpi/acpigen_pci.h>
+#include <device/device.h>
+#include <device/pci.h>
+#include "chip.h"
+
+static const char *pcie_generic_acpi_name(const struct device *dev)
+{
+	return "DEV0";
+}
+
+static void pcie_generic_fill_ssdt(const struct device *dev)
+{
+	struct drivers_pcie_generic_config *config = dev->chip_info;
+	struct acpi_dp *dsd;
+
+	if (!config || !dev || !dev->bus || !dev->bus->dev)
+		return;
+
+	if (!config->is_untrusted)
+		return;
+
+	const char *scope = acpi_device_path(dev->bus->dev);
+	const char *name = acpi_device_name(dev);
+
+	acpigen_write_scope(scope);
+	acpigen_write_device(name);
+	acpigen_write_ADR_pci_device(dev);
+
+	dsd = acpi_dp_new_table("_DSD");
+	acpi_dp_add_integer(dsd, "UntrustedDevice", 1);
+	acpi_dp_write(dsd);
+
+	acpigen_write_device_end();
+	acpigen_write_scope_end();
+
+	printk(BIOS_INFO, "%s.%s: Enable ACPI properties for %s (%s)\n", scope, name,
+	       dev_path(dev), dev->chip_ops->name);
+}
+
+struct device_operations pcie_generic_ops = {
+	.read_resources		= pci_dev_read_resources,
+	.set_resources		= pci_dev_set_resources,
+	.enable_resources	= pci_dev_enable_resources,
+	.acpi_name		= pcie_generic_acpi_name,
+	.acpi_fill_ssdt		= pcie_generic_fill_ssdt,
+};
+
+static void pcie_generic_enable(struct device *dev)
+{
+	dev->ops = &pcie_generic_ops;
+}
+
+struct chip_operations drivers_pcie_generic_ops = {
+	CHIP_NAME("PCIe Device")
+	.enable_dev = pcie_generic_enable
+};

To view, visit change 61627. To unsubscribe, or for help writing mail filters, visit settings.