1 comment:
File src/drivers/mrc_cache/mrc_cache.c:
Patch Set #2, Line 522: if (!CONFIG(VBOOT_STARTS_IN_BOOTBLOCK))
What are the semantics of CONFIG(HAS_RECOVERY_MRC_CACHE)?
Couldn't we add a dependency on CONFIG(VBOOT_STARTS_IN_BOOTBLOCK) directly to that Kconfig option, and then disable CONFIG(HAS_RECOVERY_MRC_CACHE) on appropriate boards?
Way it stands currently: No way to know if recovery mode is enabled until verified boot is ran.
Unless I'm missing something -- hasn't this always been the case for non-manual recovery? So any MRC cache code relying on vboot_recovery_mode_enabled() prior to CB:38780 with CONFIG(VBOOT_STARTS_IN_ROMSTAGE) would be inconsistently choosing the recovery cache for manual recovery, and non-recovery cache for BROKEN recovery. This seems worse than just disallowing having two separate caches at all.
To view, visit change 39221. To unsubscribe, or for help writing mail filters, visit settings.