Patch set 16:Code-Review +1
6 comments:
Patch Set #16, Line 10: its duplication in mainboards
nit: add two spaces at the beginning of the line to align the text
Patch Set #16, Line 12: Old code is rewritten with new ASL syntax
Use the same tense as the other statements:
Rewrite old code using the new ASL syntax
File src/ec/apple/acpi/ac_01.asl:
The AC files only differ in this number. What about using preprocessor to define these values?
File src/ec/apple/acpi/ac_60.asl:
Is this the bit where LIDS resides?
File src/ec/apple/acpi/lid_01.asl:
The first difference
Patch Set #16, Line 39: { 0x1d, 0x03 }
The second difference
To view, visit change 33102. To unsubscribe, or for help writing mail filters, visit settings.