Patch Set 19:
Patch Set 19:
Patch Set 19:
Patch Set 19:
NO_STAGE_CACHE --> already exists
USE_EXTERNAL_STAGE_CACHE --> depends on !NO_STAGE_CACHE (can be selected by a mainboard/SoC that provides implementation of external stage cache).
Only i issue i saw here with AMD, Gardenia board, where HAVE_ACPI_TABLE is not selected hence NO_STAGE_CACHE is enable and in same time, mainboard also selects HAVE_EXTERNAL_STAGE_CACHE. As per this mainboard expectation, it might need to make use of stage_cache hence I can't make USE_EXTERNAL_STAGE_CACHE --> depends on !NO_STAGE_CACHE
That sounds like a bug in the board?
yeah, it appears like that, as it expects stage_cache to get involved hence i'm getting un-definition error (USE_EXTERNAL_STAGE_CACHE --> depends on !NO_STAGE_CACHE)
from AMD, gardenia .config
CONFIG_RELOCATABLE_RAMSTAGE=y
CONFIG_HAVE_EXTERNAL_STAGE_CACHE=y
CONFIG_EXTERNAL_STAGE_CACHE=y
CONFIG_RELOCATABLE_MODULES=y
CONFIG_NO_STAGE_CACHE=y
In my opinion, that SoC should have:
diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig
index 78b89e3025..73869eced1 100644
--- a/src/soc/amd/stoneyridge/Kconfig
+++ b/src/soc/amd/stoneyridge/Kconfig
@@ -60,7 +60,7 @@ config CPU_SPECIFIC_OPTIONS
select C_ENVIRONMENT_BOOTBLOCK
select BOOT_DEVICE_SUPPORTS_WRITES if BOOT_DEVICE_SPI_FLASH
select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY if BOOT_DEVICE_SPI_FLASH
- select CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM
+ select CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM if HAVE_ACPI_RESUME
select PARALLEL_MP
select PARALLEL_MP_AP_WORK
select HAVE_SMI_HANDLER
What do you think? Kyosti/Marshall might be able to provide more insight.
1 comment:
Patch Set #21, Line 265: romstage
Is that really true?
To view, visit change 33116. To unsubscribe, or for help writing mail filters, visit settings.