View Change

3 comments:

• File src/soc/intel/common/basecode/reset/reset.c:

  • Patch Set #8, Line 11: do_global_reset

    force_global_reset?

  • Patch Set #8, Line 22: /* Now BIOS can write 0x06 or 0x0E to 0xCF9 port to global reset platform */

    I'd say that's included above, so drop that comment maybe

• File src/soc/intel/common/block/reset/reset.c:

  • Patch Set #7, Line 27: do_force_global_reset

    Ack

    Well, we still have do_global_reset and global_reset; why is my force_global_reset (which the function actually does, right? enforce it?) wrong?

To view, visit change 45336. To unsubscribe, or for help writing mail filters, visit settings.