Attention is currently required from: Angel Pons, Erik van den Bogaert, Frans Hendriks, Jan Samek, Jeremy Soller, Jonathon Hall, Michael Niewöhner, Michał Żygowski, Nicholas Sudsgaard, Nico Huber, Piotr Król, Sean Rhodes, Tim Crawford.
View Change
1 comment:
Patchset:
Patch Set #2:
This would be a lot easier if you would review. If we do it in multiple patches, […]
Your patch shouldn't change device state. It only should do the switch, but both changes in one patch are too much.
I also found cases for the other way: A PCIe device is set to enabled in the devicetree but the related FSP option is not set.
To view, visit change 79917. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f7e3e1dc6b3d8d6159bd4701e6fd90f4b0f67f4
Gerrit-Change-Number: 79917
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert@eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Jan Samek <jan.samek@siemens.com>
Gerrit-Reviewer: Jeremy Soller <jeremy@system76.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Reviewer: Sean Rhodes <sean@starlabs.systems>
Gerrit-Reviewer: Tim Crawford <tcrawford@system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Attention: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Attention: Jeremy Soller <jeremy@system76.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-Attention: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Attention: Jan Samek <jan.samek@siemens.com>
Gerrit-Attention: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Attention: Erik van den Bogaert <ebogaert@eltan.com>
Gerrit-Attention: Tim Crawford <tcrawford@system76.com>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Sean Rhodes <sean@starlabs.systems>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Comment-Date: Mon, 15 Jan 2024 16:03:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Jan Samek <jan.samek@siemens.com>
Gerrit-MessageType: comment