[coreboot-gerrit] Change in coreboot[master]: security/tpm/crtm.c: Fix !CONFIG_BOOTBLOCK_IN_CBFS measuring

[Werner Zeh (Code Review)]

Attention is currently required from: Nico Huber, Christian Walter, Arthur Heymans.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64418 )

Change subject: security/tpm/crtm.c: Fix !CONFIG_BOOTBLOCK_IN_CBFS measuring
......................................................................

Patch Set 1:

(1 comment)

File src/security/tpm/tspi/crtm.c:

https://review.coreboot.org/c/coreboot/+/64418/comment/8239e60a_abc61001 
PS1, Line 74: 	} /* else: TODO: Add SoC specific measurement methods. */
> > > Shouldn't we still return an error? or is this merely a best-effort […]

Well, self-measuring makes sense when there is a different root of trust which ensures that the first loaded and executed piece is trustworthy. From then one the chain of trust can be build up. So please, let us keep this functionality in