only had a brief look and probably missed some stuff, but I wonder if it would be better to move the definitions that are common for multiple SIOs in tree to a common file, keep the device-specific files and include the common header in the specific headers and keep using the specific headers in the mainboards

View Change

3 comments:

• File src/superio/nsc/common/superio_defs.h:

  • Patch Set #1, Line 34: FSD

    HWM maybe? at least on SIOs from other vendors that function block is often called HWM

  • Patch Set #1, Line 34:

    #define PC8XXXX_FSD  0x08 /* Fan speed device */
    #define PC8XXXX_ACB  0x08
    #define PC8XXXX_FSCM 0x09
    #define PC8XXXX_FMC  0x09
    

    leave different LDNs with same LDN number in the SIO-specific header iles and include the common definition header file in those header files?

• File src/superio/nsc/pc87417/pc87417.h:

  • Patch Set #1, Line 30:

    this is the only device with this LDN in the tree, so leave this definition in this header file and include the common header file here?

To view, visit change 31427. To unsubscribe, or for help writing mail filters, visit settings.