Attention is currently required from: Caveh Jalali, Daisuke Nojiri, Karthik Ramasubramanian, Nick Vaccaro, Paul Menzel, Shelley Chen.
7 comments:
Commit Message:
Patch Set #2, Line 7: Hide typec ACPI device if UCSI is supported
Please add prefix: […]
Done in latest patch.
Patch Set #2, Line 19: https://crrev.com/c/5416841 is the change for adding the feature flag
Please add a dot/period at the end of sentences.
Removed the sentence altogether in latest patch.
File src/ec/google/chromeec/ec.h:
Patch Set #7, Line 427: CBI_COMMON_CONTROL_UCSI_ENABLED
this bit position needs to be derived from ec_commands.h […]
Done
File src/ec/google/chromeec/ec.h:
Why not bool?
Functions called within google_chromeec_get_ucsi_enabled return int as well. Maybe leaving this as int makes sense too?
File src/ec/google/chromeec/ec.c:
Patch Set #2, Line 735: printk(BIOS_INFO, "Cannot check whether EC_FEATURE_UCSI_PPM is available.\n");
Log the return value?
Done
File src/ec/google/chromeec/ec.c:
Patch Set #7, Line 729: uint32_t cc
Do you want to define cc as union ec_common_control? Then, you can call cbi_get_uint32: […]
Done
File src/ec/google/chromeec/ec_acpi.c:
/* UCSI implementations do not require an ACPI device
* with mux info since the linux kernel doesn't set
* the muxes. */
Please use the recommended commenting styles.
Done in latest patch.
To view, visit change 81967. To unsubscribe, or for help writing mail filters, visit settings.