David Hendricks merged this change.

View Change

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Philipp Deppenwiese: Looks good to me, approved
mb/facebook/watson: Make turbo mode configurable (disabled by default)

Change-Id: Ief1eaab960c8fdab5bd5041b1a4f0c6ba1dd833f
Signed-off-by: David Hendricks <dhendrix@fb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32222
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/facebook/watson/Kconfig
M src/mainboard/facebook/watson/mainboard.c
2 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/facebook/watson/Kconfig b/src/mainboard/facebook/watson/Kconfig
index 609b14a..6c2f954 100644
--- a/src/mainboard/facebook/watson/Kconfig
+++ b/src/mainboard/facebook/watson/Kconfig
@@ -41,4 +41,8 @@
string
default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd"

+config ENABLE_TURBO
+ bool "Enable turbo frequency"
+ default n
+
endif # BOARD_FACEBOOK_WATSON
diff --git a/src/mainboard/facebook/watson/mainboard.c b/src/mainboard/facebook/watson/mainboard.c
index e6b7850..3a1692f 100644
--- a/src/mainboard/facebook/watson/mainboard.c
+++ b/src/mainboard/facebook/watson/mainboard.c
@@ -3,6 +3,7 @@
*
* Copyright (C) 2007-2009 coresystems GmbH
* Copyright (C) 2011 Google Inc.
+ * Copyright (C) Facebook, Inc. and its affiliates
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -14,6 +15,7 @@
* GNU General Public License for more details.
*/

+#include <cpu/intel/turbo.h>
#include <device/device.h>

/*
@@ -25,6 +27,14 @@

}

+static void mainboard_init(void *chip_info)
+{
+#if !IS_ENABLED(CONFIG_ENABLE_TURBO)
+ disable_turbo();
+#endif
+}
+
struct chip_operations mainboard_ops = {
.enable_dev = mainboard_enable,
+ .init = mainboard_init,
};

To view, visit change 32222. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief1eaab960c8fdab5bd5041b1a4f0c6ba1dd833f
Gerrit-Change-Number: 32222
Gerrit-PatchSet: 6
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: John Looney <john.looney@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: insomniac <insomniac@slackware.it>
Gerrit-MessageType: merged