July 1, 2019
5:01 p.m.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33867 ) Change subject: mb/lenovo: Add Lenovo Thinkpad Helix ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/33867/1/src/mainboard/lenovo/helix/Kconfig File src/mainboard/lenovo/helix/Kconfig: PS1: > * MAINBOARD_VENDOR is selected in top-level Kconfig (from mb/lenovo directory) […] * PXE_ROM_ID Why not? If someone wants to use iPXE on it, it's preconfigured. * CBFS_SIZE Maybe, depends on the partition layout. In my experience, it's much more bigger. -- To view, visit https://review.coreboot.org/c/coreboot/+/33867 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7dbf10bc85edb161fce077568d4ef3db91e10db7 Gerrit-Change-Number: 33867 Gerrit-PatchSet: 1 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-CC: Peter Lemenkov <lemenkov@gmail.com> Gerrit-Comment-Date: Mon, 01 Jul 2019 17:01:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Lemenkov <lemenkov@gmail.com> Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net> Gerrit-MessageType: comment