This commit does way to many things at the same time, making it hard to review.
11 comments:
Patch Set #1, Line 9: values
that should be one commit, as it's only replacing hardcoded numbers with defines it's easy to review.
Maybe even the first commit?
Patch Set #1, Line 36: post_code(POST_RAMSTAGE_DIE);
is this code reachable? doesn't run_ramstage call die()?
File src/arch/x86/postcar_loader.c:
please use die_with_post_code()
File src/cpu/intel/car/bootblock.c:
Patch Set #1, Line 26: POST_BOOTBLOCK_SOC_EARLYINIT
does postcodes need to be send before entering a function, or after all work has been done? That should be defined first and written down somewhere.
File src/cpu/intel/car/core2/cache_as_ram.S:
that one got lost
File src/cpu/intel/haswell/romstage.c:
Patch Set #1, Line 22: post_code
move before enable_lapic
Patch Set #1, Line 48: post_code
this one is missing
File src/cpu/qemu-x86/bootblock.c:
Patch Set #1, Line 9: POST_ENTRY_C_BOOTBLOCK
that doesn't match the description
Patch Set #1, Line 14: post_code
move into console_init()
File src/soc/intel/broadwell/romstage/romstage.c:
Patch Set #1, Line 37: post_code(POST_ENTRY_ROMSTAGE);
move to src/cpu/intel/car/romstage.c
File src/soc/intel/skylake/bootblock/bootblock.c:
Patch Set #1, Line 24: POST_BOOTBLOCK_SOC_EARLYINIT
move to src/lib/bootblock.c
To view, visit change 42503. To unsubscribe, or for help writing mail filters, visit settings.