Srinidhi N Kaushik has uploaded this change for review. ( https://review.coreboot.org/25420
Change subject: soc/intel: Change in timeout value for mp_init ......................................................................
soc/intel: Change in timeout value for mp_init
This patch chnages the timeout for all the mp_run_on_all_cpus calls to fix the Parking AP error.
BUG=76442753 BRANCH=none TEST=Build and boot, perform Suspend and during resume should not see "Parking APs failed" error.
Change-Id: I7f09c1407ccbcc3bae90fb3806f1c754b1d9ac09 Signed-off-by: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com --- M src/soc/intel/apollolake/chip.c M src/soc/intel/apollolake/cpu.c M src/soc/intel/common/block/cpu/mp_init.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/25420/1
diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index 1dd6daf..242ce37 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -604,7 +604,7 @@ static void drop_privilege_all(void) { /* Drop privilege level on all the CPUs */ - if (mp_run_on_all_cpus(&cpu_enable_untrusted_mode, 1000) < 0) + if (mp_run_on_all_cpus(&cpu_enable_untrusted_mode, 3000) < 0) printk(BIOS_ERR, "failed to enable untrusted mode\n"); }
diff --git a/src/soc/intel/apollolake/cpu.c b/src/soc/intel/apollolake/cpu.c index d093acc..cadf50a 100644 --- a/src/soc/intel/apollolake/cpu.c +++ b/src/soc/intel/apollolake/cpu.c @@ -241,7 +241,7 @@ smm_southbridge_enable(PWRBTN_EN | GBL_EN);
if (IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_SGX)) - mp_run_on_all_cpus(sgx_configure, 2000); + mp_run_on_all_cpus(sgx_configure, 3000); }
static const struct mp_ops mp_ops = { diff --git a/src/soc/intel/common/block/cpu/mp_init.c b/src/soc/intel/common/block/cpu/mp_init.c index 085a340..462c01a 100644 --- a/src/soc/intel/common/block/cpu/mp_init.c +++ b/src/soc/intel/common/block/cpu/mp_init.c @@ -132,7 +132,7 @@ /* Ensure to re-program all MTRRs based on DRAM resource settings */ static void post_cpus_init(void *unused) { - if (mp_run_on_all_cpus(&x86_setup_mtrrs_with_detect, 1000) < 0) + if (mp_run_on_all_cpus(&x86_setup_mtrrs_with_detect, 2000) < 0) printk(BIOS_ERR, "MTRR programming failure\n");
x86_mtrr_check();