I primarily looked at vbtn.asl (the other files seem sane I don't have a spec to reference).

I'm pretty sure that the Windows driver doesn't bother to check the chassis type (nor do anything else besides the required core functionality), so the Linux driver probably could've used a different workaround (or avoided one entirely). Regardless, there's not much we can do about unless/until someone can get their hands on the system that caused the kernel workaround to be introduced.

Patch set 4:Code-Review +1

View Change

To view, visit change 31208. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d5dc985a3cfb1d01ff164c4e67f17e6b1cdd619
Gerrit-Change-Number: 31208
Gerrit-PatchSet: 4
Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Jett Rink <jettrink@google.com>
Gerrit-Reviewer: Matt Delco <delco@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 02 Feb 2019 00:51:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment