Resolving comments for submission. We decided to submit these GPIOs as they are needed for now and debug further. The 0x5a issue still exists on certain SSDs.

View Change

7 comments:

• Commit Message:

  • Patch Set #1, Line 7: GPIOs

    Did you identify which of these are really required to fix the 0x5a issue?

    Done

  • Patch Set #1, Line 16: Run faft_bios

    I think we should do two things here: […]

    Done

• Commit Message:

  • Patch Set #3, Line 10: broken

    recovery?

    Done

  • Patch Set #3, Line 11:

    KBL
    platforms 
    

    Please reference the commit.

    Done

  • Patch Set #3, Line 16: faft_bios

    What is that?

    Done

• File src/mainboard/google/hatch/variants/baseboard/gpio.c:

  • Patch Set #1, Line 445: GPP_E4

    I pulled the SSD pins over together, so I'm not sure if this one needs to be initialized in bootbloc […]

    Done

  • Patch Set #1, Line 447: GPP_E5

    No, I am just trying to understand what the root cause of the issue is and why a GPIO needs to be in […]

    Done

To view, visit change 34484. To unsubscribe, or for help writing mail filters, visit settings.