Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38353 )
Change subject: [TESTME]asus/f2a85-m: move the rest of romstage.c code to bootblock.c ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38353/1/src/mainboard/asus/f2a85-m/... File src/mainboard/asus/f2a85-m/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38353/1/src/mainboard/asus/f2a85-m/... PS1, Line 20: #include <stdint.h>
why this is removed ?
It builds fine without <stdint.h>, and I thought it's too tiny for a separate commit.
https://review.coreboot.org/c/coreboot/+/38353/1/src/mainboard/asus/f2a85-m/... PS1, Line 26: smbus_setup
Should be kept in romstage indeed. […]
I misunderstood that we need to move all the romstage.c contents to bootblock.c . Guess this change could be abandoned, then. I'll also revert it at A88XM-E CB:30987 .