build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47831 )
Change subject: util/cbfstool: Introduce concept of mmap_window ......................................................................
Patch Set 1:
(10 comments)
https://review.coreboot.org/c/coreboot/+/47831/1/util/cbfstool/cbfstool.c File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/47831/1/util/cbfstool/cbfstool.c@15... PS1, Line 150: * Default decode window lives just below 4G boundary in host space and maps upto a 'upto' may be misspelled - perhaps 'up to'?
https://review.coreboot.org/c/coreboot/+/47831/1/util/cbfstool/cbfstool.c@15... PS1, Line 159: static unsigned convert_address(const struct region *to, const struct region *from, Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/47831/1/util/cbfstool/cbfstool.c@16... PS1, Line 160: unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/47831/1/util/cbfstool/cbfstool.c@17... PS1, Line 170: static int find_mmap_window(size_t struct_offset, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/47831/1/util/cbfstool/cbfstool.c@18... PS1, Line 184: static unsigned convert_host_to_flash(const struct buffer *region, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/47831/1/util/cbfstool/cbfstool.c@18... PS1, Line 184: static unsigned convert_host_to_flash(const struct buffer *region, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/47831/1/util/cbfstool/cbfstool.c@20... PS1, Line 202: static unsigned convert_flash_to_host(const struct buffer *region, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/47831/1/util/cbfstool/cbfstool.c@20... PS1, Line 202: static unsigned convert_flash_to_host(const struct buffer *region, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/47831/1/util/cbfstool/cbfstool.c@22... PS1, Line 225: static unsigned convert_addr_space(const struct buffer *region, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/47831/1/util/cbfstool/cbfstool.c@22... PS1, Line 225: static unsigned convert_addr_space(const struct buffer *region, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'