1 comment:
File src/soc/intel/jasperlake/fsp_params.c:
Patch Set #1, Line 94: override
Completely agree, somehow the terminology ended up sounding very strange. […]
Maybe. I wouldn't know how to call it, though.
Btw. now that I understand what this change is doing, I realized that
it's not needed. The `chip` config can be altered by the mainboard code
at any time before silicon init, e.g. the mainboard's `chip` driver's
`.init`.
We already have a lot of flexibility in coreboot. Most of these calls
to other entities I see in soc/intel/ are not needed. Sometimes because
we already have a generic mechanism in place, sometimes they only exist
because a function parameter is missing (i.e. instead of passing some
information, let the callee directly call back to ask for its parameters;
don't know what that is, it's not procedural programming).
To view, visit change 45856. To unsubscribe, or for help writing mail filters, visit settings.