Peichao Li has uploaded this change for review.

View Change

mb/google/vilboz: update GPIOs, gpio.c is unnecessary

Vilboz is completely new design so gpio.c is unnecessary
Delcare:
--AGPIO6 for EN_PWR_TOUCHPAD
--EGPIO67 for DMIC_SEL

BUG=b:157744136
BRANCH=NONE
TEST=flash the bios to vilboz DUT and test thest functions

Signed-off-by: peichao.wang <peichao.wang@bitland.corp-partner.google.com>
Change-Id: I575f8b233b56185f3281ad7127bc274bda5ea801
---
M src/mainboard/google/zork/variants/vilboz/Makefile.inc
D src/mainboard/google/zork/variants/vilboz/gpio.c
2 files changed, 0 insertions(+), 38 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/42986/1
diff --git a/src/mainboard/google/zork/variants/vilboz/Makefile.inc b/src/mainboard/google/zork/variants/vilboz/Makefile.inc
index af38c88..dc1e411 100644
--- a/src/mainboard/google/zork/variants/vilboz/Makefile.inc
+++ b/src/mainboard/google/zork/variants/vilboz/Makefile.inc
@@ -3,4 +3,3 @@
subdirs-y += ./spd

ramstage-y += variant.c
-ramstage-y += gpio.c
diff --git a/src/mainboard/google/zork/variants/vilboz/gpio.c b/src/mainboard/google/zork/variants/vilboz/gpio.c
deleted file mode 100644
index 44d3f89..0000000
--- a/src/mainboard/google/zork/variants/vilboz/gpio.c
+++ /dev/null
@@ -1,37 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
-
-#include <baseboard/gpio.h>
-#include <baseboard/variants.h>
-#include <boardid.h>
-#include <gpio.h>
-#include <soc/gpio.h>
-#include <ec/google/chromeec/ec.h>
-
-/* This table is used by dalboz variant with board version < 2. */
-static const struct soc_amd_gpio bid_1_gpio_set_stage_ram[] = {
- /* DMIC_SEL */
- PAD_GPO(GPIO_6, LOW), // Select Camera 1 DMIC
- /* EN_PWR_TOUCHPAD_PS2 */
- PAD_GPO(GPIO_67, HIGH),
-};
-
-const struct soc_amd_gpio *variant_override_gpio_table(size_t *size)
-{
- uint32_t board_version;
-
- /*
- * If board version cannot be read, assume that this is an older revision of the board
- * and so apply overrides. If board version is provided by the EC, then apply overrides
- * if version < 2.
- */
- if (google_chromeec_cbi_get_board_version(&board_version))
- board_version = 1;
-
- if (board_version < 2) {
- *size = ARRAY_SIZE(bid_1_gpio_set_stage_ram);
- return bid_1_gpio_set_stage_ram;
- }
-
- *size = 0;
- return NULL;
-}

To view, visit change 42986. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I575f8b233b56185f3281ad7127bc274bda5ea801
Gerrit-Change-Number: 42986
Gerrit-PatchSet: 1
Gerrit-Owner: Peichao Li <peichao.wang@bitland.corp-partner.google.com>
Gerrit-MessageType: newchange