2 comments:

Commit Message:
- Patch Set #1, Line 7: mb/asrock/e350m1/buildOpts.c: Fix AGESA_VERSION_STRING
  … to 1.1.0. […]
  Aren't commit summaries supposed to be short? This is already over 55 characters. Refer to the other comment as to why I don't want to add any version numbers to the commit message.
- Patch Set #1, Line 10: Change it so that it matches the other AGESA f14 boards in the tree.
  Change it from 0.0.0.1 to 1.1.0. […]
  What for? One might as well check the changed values in the single line this commit modifies.
  This change is the first one of a rather bulky patch train that is supposed to be reproducible, so it is quite annoying to have to rebase everything just because of one commit message.
  What's more, if this is to allow grepping for the version numbers, these numbers return only one or two somewhat relevant changes on gerrit, one of which was abandoned as it had been untouched for over seven years. So, I highly doubt they are useful.
  Last but not least: to me, putting the numbers being changed in the commit message feels just as bad as writing a comment like this:
```
 /* Assign the value of 3 to the variable i */
 i = 3;
```

To view, visit change 41621. To unsubscribe, or for help writing mail filters, visit settings.