Nico Huber would like Michael Niewöhner and Patrick Rudolph to review this change.

View Change

util/supermicro: Always include commonlib/bsd/compiler.h

We rely on `compiler.h` for definitions like `__packed`. Without it,
`smcbiosinfo.c` simply declared a global struct with that name, but
nothing was packed.

Change-Id: Ide055317115fc374a63812bcd3791445ca4f2dcc
Signed-off-by: Nico Huber <nico.h@gmx.de>
---
M util/supermicro/Makefile.inc
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/41784/1
diff --git a/util/supermicro/Makefile.inc b/util/supermicro/Makefile.inc
index 1aa5bcb..316cb48 100644
--- a/util/supermicro/Makefile.inc
+++ b/util/supermicro/Makefile.inc
@@ -1,9 +1,11 @@
+TOOLCPPFLAGS += -include $(top)/src/commonlib/bsd/include/commonlib/bsd/compiler.h
+
SMCBIOSINFOTOOL:= $(objutil)/supermicro/smcbiosinfo

$(SMCBIOSINFOTOOL): $(dir)/smcbiosinfo/smcbiosinfo.c
printf " HOSTCC Creating SMCBIOSINFO tool\n"
mkdir -p $(objutil)/supermicro
- $(HOSTCC) $< -o $@
+ $(HOSTCC) $(TOOLCPPFLAGS) $< -o $@

ifeq ($(CONFIG_VENDOR_SUPERMICRO),y)
ifneq ($(call strip_quotes, $(CONFIG_SUPERMICRO_BOARDID)),)

To view, visit change 41784. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide055317115fc374a63812bcd3791445ca4f2dcc
Gerrit-Change-Number: 41784
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-MessageType: newchange