Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro.

View Change

1 comment:

• File src/lib/coreboot_table.c:

  • Patch Set #16, Line 263: rec->size = sizeof(*rec);

    but handrolling serialization is so painful and fraught with bugs...

    I usually see the exact opposite ;) bugs because a compiler does something
    differently, bugs because we forgot to define __packed, all with the pain
    of hunting subtle bugs. (not to mention byte-ordering issues)

    For me, it mostly depends on the ABI specification. When having a proper table
    with byte offsets at hand, I prefer to write (de)serialization code that is
    easy to review with the table. I haven't done this often, but it worked out
    very well in CB:31018. Easy to check against the spec and the internal structs
    can be exactly as the program needs them to be without ABI constraints.

To view, visit change 57069. To unsubscribe, or for help writing mail filters, visit settings.