Paul Fagerburg submitted this change.

View Change

Approvals: build bot (Jenkins): Verified David Wu: Looks good to me, but someone else must approve Caveh Jalali: Looks good to me, but someone else must approve Paul Fagerburg: Looks good to me, approved
mb/google/volteer: Create trondo variant

Create the trondo variant of the volteer reference board by copying the
template files to a new directory named for the variant.

BUG=b:154678884
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_TRONDO

Change-Id: Ie4f9bfe4798e14f91c6cb439f5c5ab2b9ea52b51
Signed-off-by: David Wu <david_wu@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40686
Reviewed-by: Caveh Jalali <caveh@chromium.org>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/trondo/Makefile.inc
A src/mainboard/google/volteer/variants/trondo/gpio.c
A src/mainboard/google/volteer/variants/trondo/include/variant/ec.h
A src/mainboard/google/volteer/variants/trondo/include/variant/gpio.h
A src/mainboard/google/volteer/variants/trondo/overridetree.cb
7 files changed, 75 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig
index 641ece1..de77633 100644
--- a/src/mainboard/google/volteer/Kconfig
+++ b/src/mainboard/google/volteer/Kconfig
@@ -59,6 +59,7 @@
default "Halvor" if BOARD_GOOGLE_HALVOR
default "Malefor" if BOARD_GOOGLE_MALEFOR
default "Ripto" if BOARD_GOOGLE_RIPTO
+ default "Trondo" if BOARD_GOOGLE_TRONDO
default "Volteer" if BOARD_GOOGLE_VOLTEER

config MAX_CPUS
@@ -74,6 +75,7 @@
default "halvor" if BOARD_GOOGLE_HALVOR
default "malefor" if BOARD_GOOGLE_MALEFOR
default "ripto" if BOARD_GOOGLE_RIPTO
+ default "trondo" if BOARD_GOOGLE_TRONDO
default "volteer" if BOARD_GOOGLE_VOLTEER

config VARIANT_HAS_MIPI_CAMERA
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name
index f7d0909..5c674d8 100644
--- a/src/mainboard/google/volteer/Kconfig.name
+++ b/src/mainboard/google/volteer/Kconfig.name
@@ -13,6 +13,10 @@
select BOARD_GOOGLE_BASEBOARD_VOLTEER
select VARIANT_HAS_MIPI_CAMERA

+config BOARD_GOOGLE_TRONDO
+ bool "-> Trondo"
+ select BOARD_GOOGLE_BASEBOARD_VOLTEER
+
config BOARD_GOOGLE_VOLTEER
bool "-> Volteer"
select BOARD_GOOGLE_BASEBOARD_VOLTEER
diff --git a/src/mainboard/google/volteer/variants/trondo/Makefile.inc b/src/mainboard/google/volteer/variants/trondo/Makefile.inc
new file mode 100644
index 0000000..a115fcc
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/trondo/Makefile.inc
@@ -0,0 +1,8 @@
+# SPDX-License-Identifier: GPL-2.0-only
+# This file is part of the coreboot project.
+
+SPD_SOURCES =
+
+bootblock-y += gpio.c
+
+ramstage-y += gpio.c
diff --git a/src/mainboard/google/volteer/variants/trondo/gpio.c b/src/mainboard/google/volteer/variants/trondo/gpio.c
new file mode 100644
index 0000000..6c4fb52
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/trondo/gpio.c
@@ -0,0 +1,37 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/* This file is part of the coreboot project. */
+
+#include <baseboard/gpio.h>
+#include <baseboard/variants.h>
+#include <commonlib/helpers.h>
+
+/* Pad configuration in ramstage */
+static const struct pad_config gpio_table[] = {
+
+};
+
+const struct pad_config *variant_base_gpio_table(size_t *num)
+{
+ *num = ARRAY_SIZE(gpio_table);
+ return gpio_table;
+}
+
+/* Early pad configuration in bootblock */
+static const struct pad_config early_gpio_table[] = {
+
+};
+
+const struct pad_config *variant_early_gpio_table(size_t *num)
+{
+ *num = ARRAY_SIZE(early_gpio_table);
+ return early_gpio_table;
+}
+
+static const struct cros_gpio cros_gpios[] = {
+};
+
+const struct cros_gpio *variant_cros_gpios(size_t *num)
+{
+ *num = ARRAY_SIZE(cros_gpios);
+ return cros_gpios;
+}
diff --git a/src/mainboard/google/volteer/variants/trondo/include/variant/ec.h b/src/mainboard/google/volteer/variants/trondo/include/variant/ec.h
new file mode 100644
index 0000000..33e7971
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/trondo/include/variant/ec.h
@@ -0,0 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/* This file is part of the coreboot project. */
+
+#ifndef __VARIANT_EC_H__
+#define __VARIANT_EC_H__
+
+#include <baseboard/ec.h>
+
+#endif
diff --git a/src/mainboard/google/volteer/variants/trondo/include/variant/gpio.h b/src/mainboard/google/volteer/variants/trondo/include/variant/gpio.h
new file mode 100644
index 0000000..55725ad
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/trondo/include/variant/gpio.h
@@ -0,0 +1,11 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/* This file is part of the coreboot project. */
+
+#ifndef VARIANT_GPIO_H
+#define VARIANT_GPIO_H
+
+#include <baseboard/gpio.h>
+
+/* Copied from baseboard and may need to change for the new variant. */
+
+#endif
diff --git a/src/mainboard/google/volteer/variants/trondo/overridetree.cb b/src/mainboard/google/volteer/variants/trondo/overridetree.cb
new file mode 100644
index 0000000..75422d8
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/trondo/overridetree.cb
@@ -0,0 +1,4 @@
+chip soc/intel/tigerlake
+ device domain 0 on
+ end
+end

To view, visit change 40686. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4f9bfe4798e14f91c6cb439f5c5ab2b9ea52b51
Gerrit-Change-Number: 40686
Gerrit-PatchSet: 4
Gerrit-Owner: David Wu <david_wu@quanta.corp-partner.google.com>
Gerrit-Reviewer: Alex Levin <levinale@chromium.org>
Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org>
Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com>
Gerrit-Reviewer: Dossym Nurmukhanov <dossym@google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Jes Klinke <jbk@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg@chromium.org>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-MessageType: merged