Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47231 )
Change subject: soc/mediatek/mt8192: Add 4266Mbps flag for dpm ......................................................................
Patch Set 23:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47231/23//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47231/23//COMMIT_MSG@9 PS23, Line 9: freq(4266Mbps) Please add a space before the (.
https://review.coreboot.org/c/coreboot/+/47231/23//COMMIT_MSG@10 PS23, Line 10: Tested how? What is the power usage without and with this change?
https://review.coreboot.org/c/coreboot/+/47231/23/src/soc/mediatek/mt8192/dr... File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/47231/23/src/soc/mediatek/mt8192/dr... PS23, Line 40: SA_RESERVE_SUPPORT_4266, 1); Should fit on the line above.