View Change

2 comments:

• File src/mainboard/pcengines/apu2/gpio_ftns.c:

  • Patch Set #1, Line 13: if (gpio >= 0x300)

    What is w/ this 0x300 check and how does it correspond 0x300? Seems we shouldn't be open coding any […]

    I agree, but boundary checking should be enforced by SOC code.

  • Patch Set #1, Line 16: return gpio0_read32(gpio & 0x3ff);

    if a single namespace for gpios is intended to be used then gpioX_read() should be dropped entirely […]

    There are sane and insane developers, you know :)

    But really, the idea of exposing the entire GPIO ACPIMMIO memory space without any abstraction is not an API to follow.

To view, visit change 42521. To unsubscribe, or for help writing mail filters, visit settings.