Patch Set 1: Code-Review-1

IMHO, if the SoCs are similar, copy-pasting a bunch of code which results in two similar codebases doesn't make sense, and probably results in some extra maintenance burden. I'd rather see common code instead (to the extent that is possible).

Sure, and we can refactor it at some point. I'm not sure that doing that while we're actively writing the code and trying figure out what we can keep and what needs to be changed. We can definitely create bugs to go back and refactor things.

 
> IMHO, if the SoCs differ significantly, copy-pasting code then changing it sounds completely insane. I doubt that this is the case here, but in case it is, I believe the most logical approach would be "starting fresh", i.e., adding properly updated files from the start, in a patch train.

Some things are similar and some things are different. The approach that was taken for development was to base the new SOC on the old SOC code
 
> NB I am not an expert and may be mistaken.

As I said, there points to be made for both ways. Honestly, this is the more difficult approach because I have to break things down to incremental changes. That makes it easier for people to review than just pushing the new files with all of the changes already in place, but if that's what people prefer, I'd be glad to do that.

View Change

To view, visit change 32407. To unsubscribe, or for help writing mail filters, visit settings.