Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46409 )
Change subject: soc/mediatek/mt8192: eint: unmask eint event mask register ......................................................................
Patch Set 25:
(6 comments)
https://review.coreboot.org/c/coreboot/+/46409/25/src/soc/mediatek/mt8192/Ma... File src/soc/mediatek/mt8192/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46409/25/src/soc/mediatek/mt8192/Ma... PS25, Line 3: bootblock-y += eint_event.c in alphabet order
https://review.coreboot.org/c/coreboot/+/46409/25/src/soc/mediatek/mt8192/bo... File src/soc/mediatek/mt8192/bootblock.c:
https://review.coreboot.org/c/coreboot/+/46409/25/src/soc/mediatek/mt8192/bo... PS25, Line 11: #include <soc/eint_event.h> in alphabet order
https://review.coreboot.org/c/coreboot/+/46409/25/src/soc/mediatek/mt8192/in... File src/soc/mediatek/mt8192/include/soc/eint_event.h:
https://review.coreboot.org/c/coreboot/+/46409/25/src/soc/mediatek/mt8192/in... PS25, Line 5: #include <soc/addressmap.h> : #include <device/mmio.h> : #include <types.h> in alphabet order
https://review.coreboot.org/c/coreboot/+/46409/25/src/soc/mediatek/mt8192/in... PS25, Line 9: /*eint event mask cler register*/ /* eint event mask cler register */
https://review.coreboot.org/c/coreboot/+/46409/25/src/soc/mediatek/mt8192/in... PS25, Line 14: /*eint_base + 0x880 is eint_event_mask_clr register, write 1 : *can clear eint_event_mask. : */ /* eint_base + 0x880 is eint_event_mask_clr register with access type W1C. */
https://review.coreboot.org/c/coreboot/+/46409/25/src/soc/mediatek/mt8192/in... PS25, Line 19: /*unmask eint event, eint can wakeup by spm*/ /* unmask eint event, eint can wakeup by spm */