3 comments:
File src/drivers/smmstore/store.c:
Patch Set #9, Line 200: if (region_is_subregion(region_device_region(&store), &subregion)) {
If you just use rdev_chain() you'll have a region_device that is strictly the are you are about to write. Similarly, the subregion checking is already done in rdev_chain().
i.e.
if (rdev_chain(&store, &store, end, size))
fail;
Patch Set #9, Line 212: key_sz
value_sz
Patch Set #9, Line 227: if (rdev_writeat(&store, &nul, end, sizeof(nul)) != sizeof(nul)) {
Would it be better to have the equivalent of FILE such that the offset is tracked and bumped when reading/writing?
To view, visit change 30432. To unsubscribe, or for help writing mail filters, visit settings.