Thanks for the patch and welcome to coreboot! Based on your explanation and that you have tested it on your hardware, I'm happy to just take this patch without further testing. If it works for you it should work on other platforms too.

Please check out the line comments and upload another version with those addressed (at least the one about removing the function), then I'll approve it!

Thanks for the speedy reply and warm welcome, Julius! Have submitted a second version that addresses your comments.

View Change

To view, visit change 43137. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7dfb4adab20dc7eecb1b20aa2ee6355215a1521
Gerrit-Change-Number: 43137
Gerrit-PatchSet: 2
Gerrit-Owner: Sam Lewis <sam.vr.lewis@gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 07 Jul 2020 10:00:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment