Patch Set 2:
> > Patch Set 2:
>
> @Arthur/Patrick R: Do you care to take -1 back?
> So you somehow need to manually sync this Kconfig option with the
devicetree in which the eMMC controller gets disabled too? If so my
-1 stays here. If you somehow really don't want this ACPI code to
be included when the device is disabled, generate it on runtime
like told before or put it in a different file and don't include
DSDT but yet another Kconfig option does not seem like a good
solution.

Having another ASL still does not absolve us of keeping in-sync 2
things. in this approach we would have keep the devicetree and ASL
(DSDT) in sync.

Yes, that's correct.
Only remaining option is to use coreboot's ssdt generator.

View Change

To view, visit change 30614. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90c0230e845c8d02386b50b1100faf7064ecf8f6
Gerrit-Change-Number: 30614
Gerrit-PatchSet: 3
Gerrit-Owner: V Sowmya <v.sowmya@intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Mon, 28 Jan 2019 08:03:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment