1 comment:
File src/drivers/mrc_cache/mrc_cache.c:
Patch Set #2, Line 522: if (!CONFIG(VBOOT_STARTS_IN_BOOTBLOCK))
(edit: Oh, CB:38780 is just the change that broke booting on these boards anyway, so I guess it's no […]
Ya. I was following along in the other CL where this was brought up. I feel like sprinkling in these checks doesn't help readability and is just working around an implementation problem in vboot_recovery_mode_enabled().
Can you think of another way of creating less-subtle semantics or putting other dependencies in place? I understand why you took this approach, but it doesn't look to be the correct answer.
Way it stands currently: No way to know if recovery mode is enabled until verified boot is ran.
As such all checks to recovery mode enabled prior to that should just return 0? Can we put that into vboot_recovery_mode_enabled()?
if (!CONFIG(VBOOT_STARTS_IN_BOOTBLOCK)) && vboot_has_not_ran)
return 0;
For vboot_has_not_ran I think we have that semantic lying around to use, no?
I also admit it doesn't fix the implicit semantic changes that have occurred, but it seems cleaner to put this logic in one place instead of throughout the code.
To view, visit change 39221. To unsubscribe, or for help writing mail filters, visit settings.