4 comments:
File src/mainboard/google/kukui/romstage.c:
should we enum these values?
The return value is not used (only compared with 0). What's the benefit to enum them?
I think you mean &
Done
Patch Set #39, Line 79: return
printk(BIOS_ERR, "Full calibration blob executed without saving parameters. " […]
Done
if (!read_calibration_data_from_flash(&dparam, sizeof(dparam)) ||
!is_valid_dramc_param(&dparam) ||
dparam.header.config != config) {
We probably want to give more reason telling user why we choose re-calibrating data. […]
How about using 'BIOS_NOTICE'? I don't think missing flash data is an error.
To view, visit change 35110. To unsubscribe, or for help writing mail filters, visit settings.