Attention is currently required from: Hung-Te Lin, Philipp Hug, Matt DeVillier, Angel Pons, Julius Werner, Andrey Petrov, ron minnich, Elyes Haouas, Felix Held.

View Change

2 comments:

• File src/lib/imd_cbmem.c:

  • Patch Set #4, Line 21: uintptr_t top;

    It should be static

• File src/northbridge/intel/i440bx/memmap.c:

  • Patch Set #1, Line 48:

    int tseg_size = 128 * KiB * (1 << (tseg >> 1));
    		tom -= tseg_size;
    

    If anything, this belongs to a follow-up.

    I assume it works with ints here, so there should be no problems.
    I agree a potential fix should be in follow-up patch.

To view, visit change 69078. To unsubscribe, or for help writing mail filters, visit settings.